Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.errorprone:error_prone_core from 2.20.0 to 2.21.1 #2459

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 8, 2023

Bumps com.google.errorprone:error_prone_core from 2.20.0 to 2.21.1.

Release notes

Sourced from com.google.errorprone:error_prone_core's releases.

Error Prone 2.21.1

Changes:

  • Handle overlapping ranges in suppressedRegions (fixes #4040)
  • Add AddressSelection to discourage APIs that convert a hostname to a single address

Full Changelog: google/error-prone@v2.21.0...v2.21.1

Error Prone 2.21.0

New Checkers:

Fixed issues: #3976, #3986, #4001, #4002, #4026, #4027

Full Changelog: google/error-prone@v2.20.0...v2.21.0

Commits
  • c13d44e Release Error Prone 2.21.1
  • 2533218 Handle overlapping ranges in suppressedRegions
  • 449e6f4 Handle method references in renameMethodWithInvocations
  • a2d6ad7 Add an Error Prone check to discourage APIs that convert a hostname to a single
  • 2ef7ec2 Create class to share logic between ErrorProne checkers
  • c603793 Document and test why it's important to recognize TestCase.fail even though...
  • bbf7cd9 Add support in ASTHelpersSuggestions for getEnclosedElements
  • 29b0e54 Handle overlapping deletions for unused parameters
  • b18fd72 Automatic code cleanup.
  • 25c361a Suggest using code as per[]
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.20.0 to 2.21.1.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.20.0...v2.21.1)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 8, 2023
@eamonnmcmanus
Copy link
Member

We're going to need to adjust the code before we can merge this:

Warning: /home/runner/work/gson/gson/gson/src/main/java/com/google/gson/internal/bind/TypeAdapters.java:[573,35] [AddressSelection] Prefer InetAddress.getAllName to APIs that convert a hostname to a single IP address
(see https://errorprone.info/bugpattern/AddressSelection)
...
Error: warnings found and -Werror specified

For this code:

      // regrettably, this should have included both the host name and the host address
      return InetAddress.getByName(in.nextString());

I think we should probably just add @SuppressWarnings("AddressSelection") to the containing method, or introduce a local variable so we can narrow the scope of the suppression.

@eamonnmcmanus
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 8, 2023

Looks like com.google.errorprone:error_prone_core is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Aug 8, 2023
@dependabot dependabot bot deleted the dependabot/maven/com.google.errorprone-error_prone_core-2.21.1 branch August 8, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant