Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JsonAdapter documentation and tests #2442

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Improve JsonAdapter documentation and tests #2442

merged 5 commits into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. Document how JsonAdapter creates adapter instances & add tests

    @Marcono1234
    Marcono1234 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    effb8cf View commit details
    Browse the repository at this point in the history

  2. Extend JsonAdapter.nullSafe() documentation

    @Marcono1234
    Marcono1234 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d1485ef View commit details
    Browse the repository at this point in the history

  3. Improve test for JsonAdapter factory returning null 

    Existing test `JsonAdapterNullSafeTest` had misleading comments; while it
did in the end detect if null had not been handled correctly, that only
worked because the field `JsonAdapterFactory.recursiveCall` is static and
one test method therefore affected the state of the other test method.
If the test methods were run separately in different test runs, they would
not have detected if null was handled correctly, because the factory would
not have returned null.
    @Marcono1234
    Marcono1234 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a00349b View commit details
    Browse the repository at this point in the history

  4. Extend JsonAdapter nullSafe test

    @Marcono1234
    Marcono1234 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e0ebdfa View commit details
    Browse the repository at this point in the history

  5. Extend test

    @Marcono1234
    Marcono1234 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e1a0c21 View commit details
    Browse the repository at this point in the history