Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #2142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ There are a few open-source projects that can convert Java objects to JSON. Howe
Gradle:
```gradle
dependencies {
implementation 'com.google.code.gson:gson:2.9.0'
implementation("com.google.code.gson:gson:2.9.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My impression is that single quotes are preferred in Gradle scripts. So possibly it would make more sense to propose the opposite change for the Guava documentation.

Copy link
Collaborator

@Marcono1234 Marcono1234 Jul 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation("...") is probably what you see more commonly for the Kotlin build script DSL, but apparently it is also valid for the Groovy DSL, see google/guava#3673 which proposed that for Guava.
See also the Gradle documentation for an example and click the "Groovy" and "Kotlin" tabs of the code block.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the background! In that case, I think this change makes sense. But, we can't accept it until the CLA has been signed.

}
```

Expand Down