-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ConstructorConstructor creating mismatching Collection and Map instances #2068
Open
Marcono1234
wants to merge
11
commits into
google:main
Choose a base branch
from
Marcono1234:marcono1234/Collection-default-instance-creation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix ConstructorConstructor creating mismatching Collection and Map instances #2068
Marcono1234
wants to merge
11
commits into
google:main
from
Marcono1234:marcono1234/Collection-default-instance-creation
Commits on Jan 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5b83a03 - Browse repository at this point
Copy the full SHA 5b83a03View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5d7cdd - Browse repository at this point
Copy the full SHA d5d7cddView commit details
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c6aa3b1 - Browse repository at this point
Copy the full SHA c6aa3b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b6fa06 - Browse repository at this point
Copy the full SHA 2b6fa06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a63611 - Browse repository at this point
Copy the full SHA 6a63611View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9952bda - Browse repository at this point
Copy the full SHA 9952bdaView commit details -
Fix
ProtoTypeAdapter
being unable to deserialize certain repeated f……ields For example a `List<Long>` Protobuf field might internally have the Protobuf-internal `LongList` interface type. Previously Gson's ConstructorConstructor was nonetheless creating an ArrayList for this, which is wrong but worked. Now with the changes in ConstructorConstructor Gson will fail to create an instance, so this commit tries to solve this properly in ProtoTypeAdapter.
Configuration menu - View commit details
-
Copy full SHA for 1f496d7 - Browse repository at this point
Copy the full SHA 1f496d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8ca948 - Browse repository at this point
Copy the full SHA f8ca948View commit details
Commits on Sep 7, 2024
-
Don't use LinkedTreeMap for String supertypes as key & small test fix
This reverts a previous commit of this pull request, and matches the original behavior again.
Configuration menu - View commit details
-
Copy full SHA for e70a754 - Browse repository at this point
Copy the full SHA e70a754View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 86b13f2 - Browse repository at this point
Copy the full SHA 86b13f2View commit details -
Merge remote-tracking branch 'remotes/origin/main' into marcono1234/C…
…ollection-default-instance-creation
Configuration menu - View commit details
-
Copy full SHA for ae94ae8 - Browse repository at this point
Copy the full SHA ae94ae8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.