-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix incorrect inherited URLs in
pom.xml
(#2351)
Previously Maven appended the artifact ID of the modules which lead for example for the `gson` module to the incorrect URL https://github.com/google/gson/gson This can be checked with `mvn help:effective-pom`
- Loading branch information
1 parent
7f303b5
commit c34b9ff
Showing
1 changed file
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,8 @@ | |
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd" | ||
child.project.url.inherit.append.path="false"> | ||
<modelVersion>4.0.0</modelVersion> | ||
|
||
<groupId>com.google.code.gson</groupId> | ||
|
@@ -39,7 +40,9 @@ | |
<maven.compiler.testRelease>11</maven.compiler.testRelease> | ||
</properties> | ||
|
||
<scm> | ||
<!-- These attributes specify that the URLs should be inherited by the modules as is, to avoid constructing | ||
invalid URLs, see also https://maven.apache.org/ref/3.9.1/maven-model-builder/index.html#inheritance-assembly --> | ||
<scm child.scm.url.inherit.append.path="false" child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false"> | ||
<url>https://github.com/google/gson/</url> | ||
<connection>scm:git:https://github.com/google/gson.git</connection> | ||
<developerConnection>scm:git:[email protected]:google/gson.git</developerConnection> | ||
|