reuse the fields array

google · Sep 3, 2024 · 83741ec · 83741ec
1 parent c6b1964
commit 83741ec
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/gson/src/main/java/com/google/gson/internal/bind/EnumTypeAdapter.java b/gson/src/main/java/com/google/gson/internal/bind/EnumTypeAdapter.java
@@ -59,20 +59,20 @@ private EnumTypeAdapter(final Class<T> classOfT) {
       // Uses reflection to find enum constants to work around name mismatches for obfuscated
       // classes
       Field[] fields = classOfT.getDeclaredFields();
-      Field[] constantFields = new Field[fields.length];
       int constantCount = 0;
       for (Field f : fields) {
+        // Filter out non-constant fields, replacing elements as we go
         if (f.isEnumConstant()) {
-          constantFields[constantCount++] = f;
+          fields[constantCount++] = f;
         }
       }
 
-      // Truncate the constantFields array
-      constantFields = Arrays.copyOf(constantFields, constantCount);
+      // Trim the array to the new length
+      fields = Arrays.copyOf(fields, constantCount);
 
-      AccessibleObject.setAccessible(constantFields, true);
+      AccessibleObject.setAccessible(fields, true);
 
-      for (Field constantField : constantFields) {
+      for (Field constantField : fields) {
         @SuppressWarnings("unchecked")
         T constant = (T) constantField.get(null);
         String name = constant.name();