Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-github from v67 to v68 in /scrape #3398

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Bump go-github from v67 to v68 in /scrape #3398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scrape/apps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"strings"

"github.com/PuerkitoBio/goquery"
"github.com/google/go-github/v67/github"
"github.com/google/go-github/v68/github"
)

// AppRestrictionsEnabled returns whether the specified organization has
Expand Down
6 changes: 3 additions & 3 deletions scrape/apps_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"testing"

"github.com/google/go-cmp/cmp"
"github.com/google/go-github/v67/github"
"github.com/google/go-github/v68/github"
)

func Test_AppRestrictionsEnabled(t *testing.T) {
Expand Down Expand Up @@ -95,7 +95,7 @@ func Test_CreateApp(t *testing.T) {
})

if _, err := client.CreateApp(&AppManifest{
URL: github.String("https://example.com"),
URL: github.Ptr("https://example.com"),
HookAttributes: map[string]string{
"url": "https://example.com/hook",
},
Expand All @@ -113,7 +113,7 @@ func Test_CreateAppWithOrg(t *testing.T) {
})

if _, err := client.CreateApp(&AppManifest{
URL: github.String("https://example.com"),
URL: github.Ptr("https://example.com"),
HookAttributes: map[string]string{
"url": "https://example.com/hook",
},
Expand Down
2 changes: 1 addition & 1 deletion scrape/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ toolchain go1.22.0
require (
github.com/PuerkitoBio/goquery v1.9.2
github.com/google/go-cmp v0.6.0
github.com/google/go-github/v67 v67.0.0
github.com/google/go-github/v68 v68.0.0
github.com/xlzd/gotp v0.1.0
golang.org/x/net v0.32.0
)
Expand Down
4 changes: 2 additions & 2 deletions scrape/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ github.com/andybalholm/cascadia v1.3.2/go.mod h1:7gtRlve5FxPPgIgX36uWBX58OdBsSS6
github.com/google/go-cmp v0.5.2/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/go-github/v67 v67.0.0 h1:g11NDAmfaBaCO8qYdI9fsmbaRipHNWRIU/2YGvlh4rg=
github.com/google/go-github/v67 v67.0.0/go.mod h1:zH3K7BxjFndr9QSeFibx4lTKkYS3K9nDanoI1NjaOtY=
github.com/google/go-github/v68 v68.0.0 h1:ZW57zeNZiXTdQ16qrDiZ0k6XucrxZ2CGmoTvcCyQG6s=
github.com/google/go-github/v68 v68.0.0/go.mod h1:K9HAUBovM2sLwM408A18h+wd9vqdLOEqTUCbnRIcx68=
github.com/google/go-querystring v1.1.0 h1:AnCroh3fv4ZBgVIf1Iwtovgjaw/GiKJo8M8yD/fhyJ8=
github.com/google/go-querystring v1.1.0/go.mod h1:Kcdr2DB4koayq7X8pmAG4sNG59So17icRSOU623lUBU=
github.com/xlzd/gotp v0.1.0 h1:37blvlKCh38s+fkem+fFh7sMnceltoIEBYTVXyoa5Po=
Expand Down
Loading