Add EventType consts representing the X-Github-Event header values

[MaerF0x0]

What: Adds type EventType string and an EventType const for every of the types in the maps in github/messages.go

Why: So that we can do switches like

switch eventType {
    case github.EventTypeFork:
        // do stuff
     case github.EventTypeDiscussionComment, github.EventTypeIssueComment:
        // do something with either
}

Notes:

• It should be non-breaking change
• Let me know if you want the EventType used more widely including implementing type EventTyper interface{} on each of those structs

[gmlewis]

Thank you, @MaerF0x0!
Two minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

[gmlewis]

Also, please make sure all tests run locally by following step 4 of CONTRIBUTING.md and push any necessary changes to this PR.

[gmlewis]

Also, please resolve all conflicts and push (not force-push) the changes to this PR. Thank you!

[MaerF0x0]

@gmlewis Thanks for the updates. I will be able to get to this in the later half of October. Just wanted you to know I haven't forgotten about, or abandoned this :)

[gmlewis]

@gmlewis Thanks for the updates. I will be able to get to this in the later half of October. Just wanted you to know I haven't forgotten about, or abandoned this :)

Awesome! Thank you, @MaerF0x0, for the update!
No problem. We'll keep the PR open.

[MaerF0x0]

@gmlewis I rebased my branch on origin/master so it required a force push.

fixed broken test in 4aa32d2

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (2b8c7fa) to head (4aa32d2).
Report is 158 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
- Coverage   97.72%   93.01%   -4.71%     
==========================================
  Files         153      172      +19     
  Lines       13390    14848    +1458     
==========================================
+ Hits        13085    13811     +726     
- Misses        215      944     +729     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gmlewis]

Thank you, @MaerF0x0 !

I just did a quick search for a random event string in the code base, like so:

$ rg code_scanning_alert
github/repos_hooks_deliveries_test.go
148:	"code_scanning_alert":            &CodeScanningAlertEvent{},

github/messages_test.go
281:			messageType: "code_scanning_alert",

github/messages.go
52:		"code_scanning_alert":            &CodeScanningAlertEvent{},

github/orgs_audit_log_test.go
45:		"events": ["code_scanning_alert"],
143:				"events":          []interface{}{"code_scanning_alert"},

github/event_types.go
1866:// GitHub API docs: https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#code_scanning_alert

and noticed that github/messages_test.go still spells out all of these constants explicitly, which seems odd.

I'm just thinking about when the next event gets added, the developer experience of copying that string multiple places is still not fully solved.

I think the other locations are probably fine, but messages_test.go should probably be updated as well.

Thoughts?