feat: Add support for code_scanning #3256
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Ihor Hrytskiv <[email protected]>
ihor-hrytskiv
force-pushed
the
feat/code-scanning-rulesets
branch
from
9c450af
to
0dba8da
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3256 +/- ##
==========================================
- Coverage 97.72% 93.42% -4.30%
==========================================
Files 153 172 +19
Lines 13390 11922 -1468
==========================================
- Hits 13085 11138 -1947
- Misses 215 691 +476
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you, @ihor-hrytskiv!
One minor tweak, please, and also make sure to read step 4 of CONTRIBUTING.md and push (not force-push) the changes to this PR.
Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Thank you, @gmlewis and sorry for force-push |
Signed-off-by: Ihor Hrytskiv <[email protected]>
There was a problem hiding this comment.
Thank you, @ihor-hrytskiv !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Signed-off-by: Ihor Hrytskiv <[email protected]>
Signed-off-by: Ihor Hrytskiv <[email protected]>
|
@ihor-hrytskiv - can you please resolve the conflicts in this PR and push (not force-push) the updates when you get a chance? Hopefully we will then get a second LGTM+Approval and can proceed to merge. Thank you! |
| @@ -305,6 +305,34 @@ func TestRepositoryRule_UnmarshalJSON(t *testing.T) { | |||
| }, | |||
| }), | |||
| }, | |||
| "Invalid Required workflows params": { | |||
|
Thank you, @air-hand ! |
Suggestion to add support for code_scanning in Github API.
Ruleset API docs