Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add do_not_enforce_on_create to required status checks rule params #3245

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

MattMencel
Copy link
Contributor

@MattMencel MattMencel commented Aug 22, 2024

Fixes: #3244.

I signed the CLA. The fmt test and lint scripts all passed without warnings.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 22, 2024

I signed the CLA. The fmt test and lint scripts all passed without warnings.

It looks like GitHub Actions disagrees:

--- FAIL: TestRepositoryRule_UnmarshalJSON (0.01s)
    --- FAIL: TestRepositoryRule_UnmarshalJSON/Valid_required_status_checks_params (0.00s)
        repos_rules_test.go:287: RepositoryRule.UnmarshalJSON expected rule &{Type:required_status_checks Parameters:0xc0004208d0 RulesetSourceType: RulesetSource: RulesetID:0}, got &{Type:required_status_checks Parameters:0xc000420d20 RulesetSourceType: RulesetSource: RulesetID:0}

Can you please update this test and push the changes to this PR?
(There's no need to force-push in this repo because we always squash-and-merge each PR.)

Thank you, @MattMencel !

@MattMencel
Copy link
Contributor Author

I signed the CLA. The fmt test and lint scripts all passed without warnings.

It looks like GitHub Actions disagrees:

Whoopsies.... well they do now. 😄

@gmlewis gmlewis changed the title feat: add do_not_enforce_on_create to required status checks rule params feat: Add do_not_enforce_on_create to required status checks rule params Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (2b8c7fa) to head (5c88e6f).
Report is 101 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3245      +/-   ##
==========================================
- Coverage   97.72%   92.95%   -4.78%     
==========================================
  Files         153      171      +18     
  Lines       13390    11646    -1744     
==========================================
- Hits        13085    10825    -2260     
- Misses        215      727     +512     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MattMencel !
LGTM.
Merging.

@gmlewis gmlewis merged commit 882755a into google:master Aug 22, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rulesets - do not require status checks on creation
2 participants