-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for NewPullRequest #3208
Conversation
I recently mixed up "Head" and "Base" and the error message was not clear. Add some guidance to help people avoid making the same mistake. This is copied word for word from the existing Github docs.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3208 +/- ##
==========================================
- Coverage 97.72% 92.92% -4.80%
==========================================
Files 153 171 +18
Lines 13390 11582 -1808
==========================================
- Hits 13085 10763 -2322
- Misses 215 726 +511
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
Thank you, @kevinburkesegment - would you like to sign the CLA so that I can merge this, or would you prefer I open up a separate PR and copy the original text from the official GitHub documentation into that one instead? |
I believe I signed the CLA but if you're still not seeing it on your end please feel free to duplicate the work. I do not need credit, I'd just like it to be fixed so I don't make the same mistake 6 months from now. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I signed the CLA but if you're still not seeing it on your end please feel free to duplicate the work. I do not need credit, I'd just like it to be fixed so I don't make the same mistake 6 months from now. Thanks
Excellent, thank you, @kevinburkesegment !
LGTM.
Merging.
I recently mixed up "Head" and "Base" and the error message was not clear. Add some guidance to help people avoid making the same mistake.
This is copied word for word from the existing Github docs.