Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization #3197

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

laughedelic
Copy link
Contributor

@laughedelic laughedelic commented Jul 5, 2024

Fixes #3196.

BREAKING CHANGE: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization

I followed the template of this PR, fixing a similar issue: #3094.

Let me know if there is a better way to handle this. And I'm open to better naming suggestions.

Copy link

google-cla bot commented Jul 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (2b8c7fa) to head (e492cdd).
Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3197      +/-   ##
==========================================
- Coverage   97.72%   92.91%   -4.81%     
==========================================
  Files         153      171      +18     
  Lines       13390    11558    -1832     
==========================================
- Hits        13085    10739    -2346     
- Misses        215      726     +511     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis changed the title feat!: add ListIDPGroupsOptions to support the filtering parameter feat!: Replace ListOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization Jul 5, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @laughedelic .
One minor change, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/teams.go Outdated Show resolved Hide resolved
@laughedelic laughedelic requested a review from gmlewis July 5, 2024 18:37
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @laughedelic !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Jul 5, 2024
@gmlewis gmlewis changed the title feat!: Replace ListOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization feat!: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization Jul 5, 2024
@laughedelic
Copy link
Contributor Author

Hi! Is there anything I can do to move this forward?

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 23, 2024

Hi! Is there anything I can do to move this forward?

If you have any coworkers or know of any other contributors to this repo (who are all volunteers, please remember), feel free to reach out to request a code review if you are comfortable with that.

Copy link
Contributor

@arymoraes arymoraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 24, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 24, 2024

Thank you, @arymoraes !
Merging.

@gmlewis gmlewis merged commit 2cdb0ea into google:master Jul 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListIDPGroupsInOrganization is missing the filter parameter
3 participants