Add "organization" field to more events #2949
Conversation
This should cover all events that GitHub says have an organization field.
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 145 145
Lines 12720 12720
=======================================
Hits 12490 12490
Misses 156 156
Partials 74 74
|
github/event_types.go
Outdated
|
|
||
| // The following field is only present when the webhook is triggered on | ||
| // a repository belonging to an organization. | ||
| Organization *Organization `json:"organization,omitempty"` |
There was a problem hiding this comment.
Let's please name them all Org.
There was a problem hiding this comment.
I left the existing ones, as I wasn't sure if you wanted a breaking change here or not. Happy to go change them all if you don't mind the breakage.
There was a problem hiding this comment.
Oh, sorry! That will teach me to do code reviews on my Android phone. 😂
Hmmm... consistency is nice as long as we document our changes.
Sure, let's be consistent and I'll mark this as a breaking API change. 😁
There was a problem hiding this comment.
Hmmm... I'm no longer on my phone, and I'm not understanding this statement:
I left the existing ones, as I wasn't sure if you wanted a breaking change here or not. Happy to go change them all if you don't mind the breakage.
I don't see any existing organization fields in any of the structs you modified, so I don't think this is a breaking API change afterall, correct?
This field is inconsistently named throughout this file, but updating the old instances would be a breaking change, so they got left.
gmlewis
added
Breaking API Change
There was a problem hiding this comment.
Thank you, @billnapier !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Thank you, @WillAbides ! |
gmlewis
changed the title
This should cover all events that GitHub says have an organization field.
Fixes #2950