Create MarkdownService, EmojisService, CodesOfConductService and MetaService

[WillAbides]

closes #2936

This moves all Client methods from misc.go to new services.

In every case but one, the original Client method was left in place and refactored to call the new method. The exception is Client.Markdown because the old method name is now the name of the service field.

[codecov]

Codecov Report

Merging #2937 (619aee5) into master (74db58f) will decrease coverage by 0.05%.
The diff coverage is 94.64%.

@@            Coverage Diff             @@
##           master    #2937      +/-   ##
==========================================
- Coverage   98.17%   98.13%   -0.05%     
==========================================
  Files         145      148       +3     
  Lines       12767    12783      +16     
==========================================
+ Hits        12534    12544      +10     
- Misses        158      164       +6     
  Partials       75       75              

Files	Coverage Δ
github/codesofconduct.go	100.00% <100.00%> (ø)
github/emojis.go	100.00% <100.00%> (ø)
github/github.go	98.12% <100.00%> (+0.01%)	⬆️
github/markdown.go	100.00% <100.00%> (ø)
github/meta.go	86.04% <86.04%> (ø)

[gmlewis]

In keeping with our ## Other notes on code organization ## blurb in CONTRIBUTING.md,
what would you think about moving these new service objects to their own "*.go" files?

[gmlewis]

Thank you, @WillAbides !
I have some questions and a couple tweak requests, please.

[WillAbides]

@gmlewis I did the renaming you suggested and took it one further renaming EmojisService.ListEmojis to EmojisService.List.

I think you were right about renaming Markdown to Render. Even though the endpoint ends with /markdown` the description is "Render a Markdown document".

[gmlewis]

Thank you, @WillAbides !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[WillAbides]

One more possibility while we are breaking things. Would it make sense to rename MetaService.APIMeta to MetaService.Get? I would think yes, but my hesitation is that meta is kind of a weird service in that it has functions that don't have anything to do with the metadata.

[gmlewis]

One more possibility while we are breaking things. Would it make sense to rename MetaService.APIMeta to MetaService.Get? I would think yes, but my hesitation is that meta is kind of a weird service in that it has functions that don't have anything to do with the metadata.

I like it. Yes, please.

[gmlewis]

I think these changes will make it easier to remove the deprecated functions in the future.
Thoughts?

[abhijit-hota]

Hey @gmlewis, I see that the PR is waiting on a few test function renames.

Can I help in anyway to speed things up? I could raise a PR against WillAbide:nomisc with the required changes. @WillAbides

P.S., can this comment be resolved? I gather that the required changes are done.

[gmlewis]

P.S., can this comment be resolved? I gather that the required changes are done.

Thanks, @abhijit-hota - marked comment as resolved.

For the remaining items, I was interested in hearing what @WillAbides thinks about the ideas I toseed out, so let's please wait to hear.

[WillAbides]

Sorry for the late response. I lost track of this one somehow. @abhijit-hota I appreciate your willingness to step in.

@gmlewis Your suggestions make sense, so I added them. That reduced the code coverage a bit because the deprecated methods are no longer tested. IMO, there isn't a point in testing these anyway.

[gmlewis]

Thank you, @WillAbides !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[abhijit-hota]

LGTM. =)

[gmlewis]

Thank you, @abhijit-hota !
Merging.