-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linting #2903
Fix linting #2903
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2903 +/- ##
==========================================
+ Coverage 98.14% 98.17% +0.03%
==========================================
Files 143 143
Lines 12606 12609 +3
==========================================
+ Hits 12372 12379 +7
+ Misses 159 156 -3
+ Partials 75 74 -1
📢 Have feedback on the report? Share it here. |
Codecov didn't like that I modified an uncovered line, so I added a test for it. |
I'm doing a crazy amount of driving today, so will be slow to respond. I try to "approve run" of the checks when I can, but today's going to be pretty challenging, sorry. |
@gmlewis I appreciate how responsive you are on this repo. I have no expectation that you or anybody else be around on a weekend. I can see the lint results on my fork, so my feedback loop is just fine. |
# Conflicts: # example/go.mod # example/go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, @WillAbides - thank you for this huge cleanup! It is greatly appreciated!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome
Thank you, @gabriel-samfira ! |
I noticed that
.golangci.yml
had some commented out and disabled linters. This PR fixes that. It also uncomments "example" from the GitHub action.Running
go mod tidy -compat 1.17
fixed the "no go files to analyze" error linting "examples".1For the linting issues, I updated
.golangci-lint
and fixed the issues that it found.I think most of the changes are obvious, but I want to mention a few things:
stringifyValue
to accept a*bytes.Buffer
instead of anio.Writer
because the linter knows thatBuffer.Write
always returns nil errors.authorizations_test.go
Footnotes
examples/go.* changes were originally part of this PR, but merging Remove dependency on "golang.org/x/oauth2" #2895 removed them from the diff. ↩