-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix old_name
field in AuditEntry
#2849
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 138 138
Lines 12318 12318
=======================================
Hits 12080 12080
Misses 162 162
Partials 76 76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lmartinking !
Now worries. I'm glad you caught it before I cut the new release. 😄
@gmlewis I have one more field to add, which I will do in another PR |
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
@gmlewis do you want the structs to mirror the shape of the API or would you prefer it flattened? Which was why I had it as a composite member. |
We typically do not use composite members in this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lmartinking !
LGTM.
Merging.
old_name
field in AuditEntry
is incorrectly mapped from the JSON returned by the Audit Log APIold_name
field in AuditEntry
Much to my chagrin, the audit log view in the site manager does not follow the shape of the API response.
I previously raised a PR #2843 which was merged yesterday. Unfortunately, it does not work with the payload returned from the API.
My sincere apologies about this.