-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repo rules bypass settings #2831
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2831 +/- ##
==========================================
- Coverage 98.06% 98.06% -0.01%
==========================================
Files 137 137
Lines 12289 12287 -2
==========================================
- Hits 12051 12049 -2
Misses 162 162
Partials 76 76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @o-sama !
LGTM.
@liaodaniel - could you please look at these breaking API changes since you are the original author of this section of code and make sure you are happy with them?
It seems the breaking change was introduced by GitHub (point 2 here): https://github.blog/changelog/2023-06-27-repository-rules-public-beta-updates/ The latest change in master added a couple of test cases related to organization rulesets which used |
Yep, this looks good from my end. Part of me felt that I probably should have waited a bit until the feature was out of beta before introducing it but the feature seemed too compelling to wait 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @liaodaniel ! |
This PR reconciles library with GitHub API for the following regarding repo rulesets:
BypassMode
should be part ofBypassActor
.ActorType
possible values documentation updated to match API docs.Ruleset
ID field changed toInt64
pointer and addedomitempty
to allow for nil, ruleset ID is unknown prior to creation and is not required when sending a POST request to create ruleset.