Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repository struct to SecretScanningAlert #2823

Conversation

emilva
Copy link
Contributor

@emilva emilva commented Jun 28, 2023

Add support for getting Repository when listing secret scanning alerts for enterprise

There is no easy way of getting the org/repo when listing secret scanning alerts for enterprise in the current struct. The API returns the Repository field, and with this change it will be included in the SecretScanningAlert struct

…s for Enterprise

There is no easy way of getting the org/repo when listing secret scanning alerts for enterprise in the current struct. The API returns the Repository, and with this change it will be included in the SecretScanningAlert
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #2823 (dc78e50) into master (96726d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2823   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         136      136           
  Lines       12279    12279           
=======================================
  Hits        12041    12041           
  Misses        162      162           
  Partials       76       76           
Impacted Files Coverage Δ
github/secret_scanning.go 100.00% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @emilva !
LGTM.
Merging.

@gmlewis gmlewis merged commit 7a8ab98 into google:master Jun 28, 2023
@emilva emilva deleted the add-repo-to-enterprise-secret-scanning-alerts-list branch June 28, 2023 21:32
@emilva
Copy link
Contributor Author

emilva commented Jun 28, 2023

Thank you for the quick merge 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants