Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListIDPGroupsInOrganization is missing the filter parameter #3196

Closed
laughedelic opened this issue Jul 5, 2024 · 0 comments · Fixed by #3197
Closed

ListIDPGroupsInOrganization is missing the filter parameter #3196

laughedelic opened this issue Jul 5, 2024 · 0 comments · Fixed by #3197
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). enhancement good first issue

Comments

@laughedelic
Copy link
Contributor

ListIDPGroupsInOrganization function that implements the /orgs/ORG/team-sync/groups endpoint, doesn't have the parameter to pre-filter results:

q string

Filters the results to return only those that begin with the value specified by this parameter. For example, a value of ab will return results that begin with "ab".

For organizations that have thousands of IdP groups, this makes using this function very slow. Please see integrations/terraform-provider-github#1809 for more context on how this affects the GitHub Terraform provider.

I'm requesting to add this parameter to the function to fully implement the API specification and enable downstream consumers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). enhancement good first issue
Projects
None yet
2 participants