Apply suggestions from code review

Co-authored-by: Glenn Lewis <[email protected]>
google · Jul 4, 2023 · 3881d6f · 3881d6f
1 parent 78d5ca8
commit 3881d6f
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 17 deletions.
diff --git a/github/github-accessors.go b/github/github-accessors.go
diff --git a/github/github-accessors_test.go b/github/github-accessors_test.go
diff --git a/github/orgs_rules_test.go b/github/orgs_rules_test.go
@@ -71,7 +71,7 @@ func TestOrganizationsService_GetAllOrganizationRulesets(t *testing.T) {
 	})
 }
 
-func TestOrganizationsService_CreateOrganizationRulesetRepoNames(t *testing.T) {
+func TestOrganizationsService_CreateOrganizationRuleset_RepoNames(t *testing.T) {
 	client, mux, _, teardown := setup()
 	defer teardown()
 
@@ -392,7 +392,7 @@ func TestOrganizationsService_CreateOrganizationRulesetRepoNames(t *testing.T) {
 	})
 }
 
-func TestOrganizationsService_CreateOrganizationRulesetRepoIds(t *testing.T) {
+func TestOrganizationsService_CreateOrganizationRuleset_RepoIDs(t *testing.T) {
 	client, mux, _, teardown := setup()
 	defer teardown()
 
@@ -541,8 +541,8 @@ func TestOrganizationsService_CreateOrganizationRulesetRepoIds(t *testing.T) {
 				Include: []string{"refs/heads/main", "refs/heads/master"},
 				Exclude: []string{"refs/heads/dev*"},
 			},
-			RepositoryId: &RulesetRepositoryIdsConditionParameters{
-				RepositoryIds: []int64{123, 456},
+			RepositoryID: &RulesetRepositoryIDsConditionParameters{
+				RepositoryIDs: []int64{123, 456},
 			},
 		},
 		Rules: []*RepositoryRule{
@@ -625,8 +625,8 @@ func TestOrganizationsService_CreateOrganizationRulesetRepoIds(t *testing.T) {
 				Include: []string{"refs/heads/main", "refs/heads/master"},
 				Exclude: []string{"refs/heads/dev*"},
 			},
-			RepositoryId: &RulesetRepositoryIdsConditionParameters{
-				RepositoryIds: []int64{123, 456},
+			RepositoryID: &RulesetRepositoryIDsConditionParameters{
+				RepositoryIDs: []int64{123, 456},
 			},
 		},
 		Rules: []*RepositoryRule{

diff --git a/github/repos_rules.go b/github/repos_rules.go
@@ -41,17 +41,17 @@ type RulesetRepositoryNamesConditionParameters struct {
 	Protected *bool    `json:"protected,omitempty"`
 }
 
-// RulesetRepositoryIdsConditionParameters represents the conditions object for repository_ids.
-type RulesetRepositoryIdsConditionParameters struct {
-	RepositoryIds []int64 `json:"repository_ids,omitempty"`
+// RulesetRepositoryIDsConditionParameters represents the conditions object for repository_ids.
+type RulesetRepositoryIDsConditionParameters struct {
+	RepositoryIDs []int64 `json:"repository_ids,omitempty"`
 }
 
 // RulesetCondition represents the conditions object in a ruleset.
-// Set either RepositoryName or RepositoryId, not both
+// Set either RepositoryName or RepositoryID, not both.
 type RulesetConditions struct {
 	RefName        *RulesetRefConditionParameters             `json:"ref_name,omitempty"`
 	RepositoryName *RulesetRepositoryNamesConditionParameters `json:"repository_name,omitempty"`
-	RepositoryId   *RulesetRepositoryIdsConditionParameters   `json:"repository_id,omitempty"`
+	RepositoryID   *RulesetRepositoryIDsConditionParameters   `json:"repository_id,omitempty"`
 }
 
 // RulePatternParameters represents the rule pattern parameters.