Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] BUFIX: Generated typescript imports parent directory #8338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hhvrc
Copy link

@hhvrc hhvrc commented Jun 24, 2024

This fixes something that seems to be an edgecase where the entry file for a directory will include its own parent directory in the childrens relative paths.

Example:

namespace A.B.C;

table MyTable {
  test:string;
}

Output:

a\b\c.ts

// automatically generated by the FlatBuffers compiler, do not modify

/* eslint-disable @typescript-eslint/no-unused-vars, @typescript-eslint/no-explicit-any, @typescript-eslint/no-non-null-assertion */

export { MyTable } from './b/c/my-table';

this should be export { MyTable } from './c/my-table';

I'm not quite sure if my fix is the way to go about it but it works for now for my use case.

Copy link

google-cla bot commented Jun 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added c++ codegen Involving generating code from schema javascript typescript labels Jun 24, 2024
@bjornharrtell
Copy link
Collaborator

Also not sure about the fix but I'll let it run through the tests.

@hhvrc
Copy link
Author

hhvrc commented Jun 26, 2024

The build failing seems to be unrelated to the PR, there is a file lock error

@hhvrc
Copy link
Author

hhvrc commented Jun 27, 2024

@bjornharrtell could you re-run the failed pipelines?

@bjornharrtell
Copy link
Collaborator

@hhvrc nope I'm just a janitor here. 😂

@hhvrc
Copy link
Author

hhvrc commented Jul 1, 2024

are you able to bump anyone to re-run failed tests @bjornharrtell ?

@hhvrc
Copy link
Author

hhvrc commented Jul 2, 2024

Maybe you can re-run the failed tests @dbaileychess ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema javascript typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants