-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created USFS_GTAC_LCMS_v2022-8.jsonnet for LCMS data release #523
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Pairs with #523 STAC Collection Jsonnet: - Add a version variable - Fit to 80 columns - Match the visualization lookat to the example script - Remove unnecessary `.0` - Tighten visualization multi-line entries Example script: - Add "thematic" to the "Change" display name PiperOrigin-RevId: 528871127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You will need to make an example script for the dataset
- Give a look at the cleanup I've proposed for 2021-7 in USFS_GTAC_LCMS: cleanup #524
local self_ee_catalog_url = ee_const.ee_catalog_url + basename; | ||
local catalog_subdir_url = ee_const.catalog_base + subdir + '/'; | ||
|
||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right after the line with {
, add this:
// TODO(schwehr): Remove when the dataset is ready.
'gee:skip_indexing': true,
], | ||
id: id, | ||
title: 'USFS Landscape Change Monitoring System v2022.8 (Conterminous United States and Southeastern Alaska)', | ||
version: 'v2022.8', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless v
is a part of the actual version number, please remove it. And if it's the case the the v is not a part of the version, I'll remove it from the old ones. Typically the v
is only there to make it obvious that those characters following are a version, e.g. in a title or asset id
* **Sentinel-Hub, 2021.** | ||
Sentinel 2 Cloud Detector. [Online]. | ||
Available at: [https://github.com/sentinel-hub/sentinel2-cloud-detector](https://github.com/sentinel-hub/sentinel2-cloud-detector) | ||
(Accessed: 2021) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop the accessed line.
Pairs with #523 STAC Collection Jsonnet: - Add a version variable - Fit to 80 columns - Match the visualization lookat to the example script - Remove unnecessary `.0` - Tighten visualization multi-line entries Example script: - Add "thematic" to the "Change" display name PiperOrigin-RevId: 528871127
The proposed changes look good to me. I fixed the changes you included in the email.
For the example script are there instructions on how to generate the example script in the google docs Simon shared? I see example script in the Process overview, but may not be seeing additional information further in the document.
Once I generate the example script I can do another pull request
From: Kurt Schwehr ***@***.***>
Sent: Tuesday, May 2, 2023 2:31 PM
To: google/earthengine-catalog ***@***.***>
Cc: Heyer, Joshua (CTR) - FS, UT ***@***.***>; Author ***@***.***>
Subject: Re: [google/earthengine-catalog] Created USFS_GTAC_LCMS_v2022-8.jsonnet for LCMS data release (PR #523)
@schwehr requested changes on this pull request.
* You will need to make an example script for the dataset
* Give a look at the cleanup I've proposed for 2021-7 in #524<#524>
________________________________
In catalog/USFS/USFS_GTAC_LCMS_v2022-8.jsonnet<#523 (comment)>:
+local subdir = 'USFS';
+
+local ee_const = import 'earthengine_const.libsonnet';
+local ee = import 'earthengine.libsonnet';
+local spdx = import 'spdx.libsonnet';
+
+local license = spdx.proprietary;
+
+local basename = std.strReplace(id, '/', '_');
+local latest_basename = std.strReplace(latest_id, '/', '_');
+local predecessor_basename = std.strReplace(predecessor_id, '/', '_');
+local base_filename = basename + '.json';
+local self_ee_catalog_url = ee_const.ee_catalog_url + basename;
+local catalog_subdir_url = ee_const.catalog_base + subdir + '/';
+
+{
Right after the line with {, add this:
// TODO(schwehr): Remove when the dataset is ready.
'gee:skip_indexing': true,
________________________________
In catalog/USFS/USFS_GTAC_LCMS_v2022-8.jsonnet<#523 (comment)>:
+local predecessor_basename = std.strReplace(predecessor_id, '/', '_');
+local base_filename = basename + '.json';
+local self_ee_catalog_url = ee_const.ee_catalog_url + basename;
+local catalog_subdir_url = ee_const.catalog_base + subdir + '/';
+
+{
+ stac_version: ee_const.stac_version,
+ type: ee_const.stac_type.collection,
+ stac_extensions: [
+ ee_const.ext_eo,
+ ee_const.ext_sci,
+ ee_const.ext_ver,
+ ],
+ id: id,
+ title: 'USFS Landscape Change Monitoring System v2022.8 (Conterminous United States and Southeastern Alaska)',
+ version: 'v2022.8',
Unless v is a part of the actual version number, please remove it. And if it's the case the the v is not a part of the version, I'll remove it from the old ones. Typically the v is only there to make it obvious that those characters following are a version, e.g. in a title or asset id
________________________________
In catalog/USFS/USFS_GTAC_LCMS_v2022-8.jsonnet<#523 (comment)>:
+ * **Kennedy, R. E., Yang, Z., and Cohen, W. B., 2010.**
+ Detecting trends in forest disturbance and recovery using yearly Landsat time series: 1.
+ LandTrendr - Temporal segmentation algorithms. In Remote Sensing of Environment.
+ *Science Direct*,
+ 114(12): 2897-2910
+ [doi:10.1016/j.rse.2010.07.008](https://doi.org/10.1016/j.rse.2010.07.008)
+
+ * **Kennedy, R., Yang, Z., Gorelick, N., Braaten, J., Cavalcante, L., Cohen, W., and Healey, S., 2018.**
+ Implementation of the LandTrendr Algorithm on Google Earth Engine. In Remote Sensing. *MDPI*,
+ 10(5): 691
+ [doi:10.3390/rs10050691](https://doi.org/10.3390/rs10050691)
+
+ * **Sentinel-Hub, 2021.**
+ Sentinel 2 Cloud Detector. [Online].
+ Available at: [https://github.com/sentinel-hub/sentinel2-cloud-detector](https://github.com/sentinel-hub/sentinel2-cloud-detector)
+ (Accessed: 2021)
I think we can drop the accessed line.
-
Reply to this email directly, view it on GitHub<#523 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQHB45JQ4FAWBCP2ED22K2LXEFVILANCNFSM6AAAAAAXTOKO44>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.
|
Pairs with #523 STAC Collection Jsonnet: - Add a version variable - Fit to 80 columns - Match the visualization lookat to the example script - Remove unnecessary `.0` - Tighten visualization multi-line entries Example script: - Add "thematic" to the "Change" display name PiperOrigin-RevId: 528871127
Pairs with #523 STAC Collection Jsonnet: - Add a version variable - Fit to 80 columns - Match the visualization lookat to the example script - Remove unnecessary `.0` - Tighten visualization multi-line entries Example script: - Add "thematic" to the "Change" display name PiperOrigin-RevId: 528871127
Pairs with #523 STAC Collection Jsonnet: - Add a version variable - Fit to 80 columns - Match the visualization lookat to the example script - Remove unnecessary `.0` - Tighten visualization multi-line entries Example script: - Add "thematic" to the "Change" display name PiperOrigin-RevId: 529090954
Created USFS_GTAC_LCMS_v2022-8.jsonnet for LCMS data release