Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created USFS_GTAC_LCMS_v2022-8.jsonnet for LCMS data release #523

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshheyer
Copy link
Contributor

@joshheyer joshheyer commented May 2, 2023

Created USFS_GTAC_LCMS_v2022-8.jsonnet for LCMS data release

@google-cla
Copy link

google-cla bot commented May 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@schwehr schwehr self-requested a review May 2, 2023 19:54
copybara-service bot pushed a commit that referenced this pull request May 2, 2023
Pairs with #523

STAC Collection Jsonnet:
- Add a version variable
- Fit to 80 columns
- Match the visualization lookat to the example script
- Remove unnecessary `.0`
- Tighten visualization multi-line entries

Example script:
- Add "thematic" to the "Change" display name

PiperOrigin-RevId: 528871127
Copy link
Contributor

@schwehr schwehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local self_ee_catalog_url = ee_const.ee_catalog_url + basename;
local catalog_subdir_url = ee_const.catalog_base + subdir + '/';

{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right after the line with {, add this:

  // TODO(schwehr): Remove when the dataset is ready.
  'gee:skip_indexing': true,

],
id: id,
title: 'USFS Landscape Change Monitoring System v2022.8 (Conterminous United States and Southeastern Alaska)',
version: 'v2022.8',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless v is a part of the actual version number, please remove it. And if it's the case the the v is not a part of the version, I'll remove it from the old ones. Typically the v is only there to make it obvious that those characters following are a version, e.g. in a title or asset id

* **Sentinel-Hub, 2021.**
Sentinel 2 Cloud Detector. [Online].
Available at: [https://github.com/sentinel-hub/sentinel2-cloud-detector](https://github.com/sentinel-hub/sentinel2-cloud-detector)
(Accessed: 2021)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop the accessed line.

copybara-service bot pushed a commit that referenced this pull request May 2, 2023
Pairs with #523

STAC Collection Jsonnet:
- Add a version variable
- Fit to 80 columns
- Match the visualization lookat to the example script
- Remove unnecessary `.0`
- Tighten visualization multi-line entries

Example script:
- Add "thematic" to the "Change" display name

PiperOrigin-RevId: 528871127
@joshheyer
Copy link
Contributor Author

joshheyer commented May 2, 2023 via email

copybara-service bot pushed a commit that referenced this pull request May 2, 2023
Pairs with #523

STAC Collection Jsonnet:
- Add a version variable
- Fit to 80 columns
- Match the visualization lookat to the example script
- Remove unnecessary `.0`
- Tighten visualization multi-line entries

Example script:
- Add "thematic" to the "Change" display name

PiperOrigin-RevId: 528871127
copybara-service bot pushed a commit that referenced this pull request May 3, 2023
Pairs with #523

STAC Collection Jsonnet:
- Add a version variable
- Fit to 80 columns
- Match the visualization lookat to the example script
- Remove unnecessary `.0`
- Tighten visualization multi-line entries

Example script:
- Add "thematic" to the "Change" display name

PiperOrigin-RevId: 528871127
copybara-service bot pushed a commit that referenced this pull request May 3, 2023
Pairs with #523

STAC Collection Jsonnet:
- Add a version variable
- Fit to 80 columns
- Match the visualization lookat to the example script
- Remove unnecessary `.0`
- Tighten visualization multi-line entries

Example script:
- Add "thematic" to the "Change" display name

PiperOrigin-RevId: 529090954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants