Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple fonts from Google #1901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kuanyili
Copy link

Strip interpolation to prevent the font list from being unexpectedly merged into one single string element.

When we have these SCSS variables set in assets/scss/_variables_project.scss

$google_font_name: "Noto Sans", "Noto Sans TC";
$google_font_family: "Noto+Sans:300,300i,400,400i,700,700i|Noto+Sans+TC:300,400,700";

Before the patch, we have this in our generated main.css

font-family: "Noto Sans, Noto Sans TC", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";

and this after the patch

font-family: "Noto Sans", "Noto Sans TC", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";

References

Strip interpolation to prevent the font list from being unexpectedly
merged into one single string element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant