Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check links are correct and fix those that aren't #1502

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adetaylor
Copy link
Collaborator

Fixes #957

@mgeisler
Copy link
Collaborator

Thanks @adetaylor! I rebased this on top of main and there are a few new errors — in addition to the ones in the translations.

You could update the translations yourself, we could disable checking links there, or perhaps some other approach?

Testing this out it's nice: it caches the results and won't slow down the build (or mdbook serve).

@adetaylor
Copy link
Collaborator Author

You could update the translations yourself, we could disable checking links there, or perhaps some other approach?

It actually looked to be a little fiddly to update the translations, since it appears that they do link to pages which may (or may not) actually exist when your browser is set to a different language. I think it possibly does need the actual translators to go through the mistakes.

I'm not quite sure what to do here. Disabling the link checking for translations seems bad, but perhaps as an interim step we should do that?

@randomPoison
Copy link
Collaborator

@adetaylor I'm in favor of disabling broken link checking for translations 👍 At least ensuring that the link is correct in the original English is an improvement of the current situation, and we can continue to fix broken links in the translations manually until we can figure out how to automatically valid links in translations.

Can you rebase this onto main and update it to only check the English slides?

@randomPoison randomPoison added the waiting for author Waiting on the issue author to reply label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting on the issue author to reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for broken links in CI
4 participants