Bumble hid #295

SneKarnataki · 2023-09-21T12:03:58Z

Bumble HID Host implementation.

…umble_hid

Includes: 1. HID Host implementation - hid.py 2. HID application to test Host with 3rd party HID Device application - run_hid_host.py 3. HID supporting files for testing - hid_report_parser.py & hid_key_map.py Commands to run the application: Default application: python run_hid_host.py classic1.json usb:0 <device bd-addr> Menu options for testing (Get/Set): python run_hid_host.py classic1.json usb:0 <device bd-addr> test-mode CuttleFish:tcp-client:127.0.0.1:7300 Application used for testing as Device : Bluetooth Keyboard & Mouse-5.3.0.apk Note: Change in sdp.py file while testing hid profile, TEXT_STRING: lambda x: DataElement(DataElement.TEXT_STRING, x.decode('utf8')) changed to TEXT_STRING: lambda x: DataElement(DataElement.TEXT_STRING, x) as we were facing error "UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa1 in position 4: invalid start byte" while fetching sdp records.

TEXT_STRING: lambda x: DataElement(DataElement.TEXT_STRING, x.decode('utf8')) changed to TEXT_STRING: lambda x: DataElement(DataElement.TEXT_STRING, x) as we were facing error "UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa1 in position 4: invalid start byte" while fetching sdp records.

bumble/hid.py

bumble/sdp.py

bumble/hid.py

examples/run_hid_host.py

bumble/hid.py

SneKarnataki · 2023-09-27T12:13:21Z

Hi zxzxwu, barbibulle,

Thank you for your comment. We have checked-in the updated files in bumble_hid branch.
Request you to provide any feedback.

Regards,
LTIMindtree Team

bumble/hid.py

bumble/sdp.py

bumble/hid.py

…ntants to Message Class Commit for enum and dataclass

Naming conventions

SneKarnataki · 2023-10-05T12:42:22Z

Hi all,

We have updated review comments.
Thank you.

Regards,
LTIMindtree Team

bumble/hid.py

examples/run_hid_host.py

SneKarnataki · 2023-10-10T12:24:25Z

Hi barbibulle,
Thank you for inputs.
We have updated the file.

Regards,
LTIMindtree team

barbibulle · 2023-10-11T05:07:33Z

Hi barbibulle, Thank you for inputs. We have updated the file.

Regards, LTIMindtree team

This looks good, thanks. Please see a couple new (minor) comments I added as I was reading through the code again.

Also, please run the formatter before this can be merged (see the output of the GitHub actions to see the pre-commit checks that failed). You can run the formatter by running invoke project.format from the top level (you'll need to `pip install -e ".[development]" to ensure you have the proper linter and formatter installed so you can run the pre-commit checks including the linter and formatter.

Thanks.

SneKarnataki · 2023-10-11T06:41:35Z

Hi barbibulle, Thank you for inputs. We have updated the file.
Regards, LTIMindtree team

This looks good, thanks. Please see a couple new (minor) comments I added as I was reading through the code again.

Also, please run the formatter before this can be merged (see the output of the GitHub actions to see the pre-commit checks that failed). You can run the formatter by running invoke project.format from the top level (you'll need to `pip install -e ".[development]" to ensure you have the proper linter and formatter installed so you can run the pre-commit checks including the linter and formatter.

Thanks.

Thank you barbibulle. I was able to perform "invoke project.format". But I am unable to view "Please see a couple new (minor) comments I added as I was reading through the code again." comments in PR.

Executed formatter on file.

bumble/hid.py

barbibulle · 2023-10-11T15:12:15Z

Hi barbibulle, Thank you for inputs. We have updated the file.
Regards, LTIMindtree team

This looks good, thanks. Please see a couple new (minor) comments I added as I was reading through the code again.
Also, please run the formatter before this can be merged (see the output of the GitHub actions to see the pre-commit checks that failed). You can run the formatter by running invoke project.format from the top level (you'll need to `pip install -e ".[development]" to ensure you have the proper linter and formatter installed so you can run the pre-commit checks including the linter and formatter.
Thanks.

Thank you barbibulle. I was able to perform "invoke project.format". But I am unable to view "Please see a couple new (minor) comments I added as I was reading through the code again." comments in PR.

Sorry about that, the two comments were pending and I forgot to send them. They should be visible now.

uael

Good job 🎉

bumble/hid.py

barbibulle · 2023-10-12T00:44:12Z

@SneKarnataki the "Code format and lint check" GitHub action still fails on this PR (a couple places where the typing needs to be fixed). Can you check the output of the GitHub action and fix the issue before we can merge?
(I recommend running invoke project.pre-commit locally before pushing commits, this way you can catch most of these error in advance).

uael · 2023-10-16T16:35:43Z

One more format issue 🙏

diff --git a/examples/hid_report_parser.py b/examples/hid_report_parser.py
index e5f407f..61561b3 100644
--- a/examples/hid_report_parser.py
+++ b/examples/hid_report_parser.py
@@ -139,7 +139,6 @@ class Mouse:
 
 # ------------------------------------------------------------------------------
 class ReportParser:
-
     @staticmethod
     def parse_input_report(input_report: bytes) -> None:

SneKarnataki · 2023-10-17T07:43:48Z

Thank you all for guiding our first GitHub checkin and helping to make it optimized.

Regards,
LTIMindtree

rdhavan and others added 6 commits September 15, 2023 06:45

Hid profile implemenation. Empty file

de7e9bc

Trial to commit in dhavan repo

771f2c0

Merge branch 'bumble_hid' of https://github.com/rdhavan/bumble into b…

eda4f59

…umble_hid

Trial checkin code

17e668d

uael requested review from barbibulle, DeltaEvo and uael September 21, 2023 14:35