Update to source_gen 0.9.0 #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows using `built_value` along side other `source_gen` based generators that output to `.g.dart` part file. This is a breaking change because the "header" can no longer be supported. - Switch to `SharedPartBuilder` and add the required part ID argument. - Move builds to the cache and update the new generated extension. - Apply the `source_gen|combining_builder` to merge part files back into a `.g.dart` file. - Remove the example `build.yaml` since it was only setting a `header`. - Update test cases to keep using it as if it was a standalone part builder.
davidmorgan
reviewed
Jul 25, 2018
| @@ -1,5 +1,5 @@ | |||
| name: built_value_generator | |||
There was a problem hiding this comment.
Please run tool/use_local_deps and update the PR; it will update all the yaml files to use the unreleased version, so the presubmit results are meaningful.
There was a problem hiding this comment.
ran the tool and regenerated the example files.
|
Thanks! |
|
What can |
|
@zoechi - I filed an issue with the reasoning and a potential solution at dart-lang/source_gen#370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using
built_valuealong side othersource_genbasedgenerators that output to
.g.dartpart file. This is a breaking changebecause the "header" can no longer be supported.
SharedPartBuilderand add the required part ID argument.source_gen|combining_builderto merge part files back intoa
.g.dartfile.build.yamlsince it was only setting aheader.builder.
This change is