Fix target name according to current build #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ikicha PTAL |
ikicha
approved these changes
Aug 29, 2023
|
LGTM, @jemoreira, WDYT? |
jemoreira
reviewed
Aug 29, 2023
| @@ -27,12 +27,15 @@ function parse_opts() { | |||
| ARCH=$2 | |||
| case "${ARCH}" in | |||
| x86) | |||
| TARGET='aosp_x86-trunk_staging-userdebug' | |||
There was a problem hiding this comment.
Please double check that these are the right targets: The original ones had cf and phone in them, but these don't.
It's also strange that the target for arm64 is a cf phone, but those for intel are not even cuttlefish.
There was a problem hiding this comment.
Thanks. Updated x86-64 target as cf target.
But I noticed that there is no cf target for x86 .
What should be the proper target for x86?
There was a problem hiding this comment.
@jemoreira PTAL
retroinspect
force-pushed
the
aosp-branch-target-arm
branch
from
833546b
to
0bbd66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aosp_cf_arm64_only_phone-trunk_staging-userdebugThis resolves discussion on #349