QB4W Fully Connected Operator #6673
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digantdesai
reviewed
Jul 3, 2024
| @@ -460,6 +460,310 @@ enum xnn_status xnn_create_fully_connected_nc_qd8_f16_qc4w( | |||
| fully_connected_op_out); | |||
| } | |||
|
|
|||
| enum xnn_status xnn_create_fully_connected_nc_qd8_f16_qb4w( | |||
There was a problem hiding this comment.
do you think we can share logic with other create functions and use create_fully_connected_nc? For both fp16 and fp32?
GregoryComer
force-pushed
the
qb4w-operator
branch
from
ad3e8cf
to
afb5ca8
Compare
GregoryComer
force-pushed
the
qb4w-operator
branch
from
7deed0a
to
0ef4ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add operator-API level support for qb4w (4-bit blockwise-quantized weight) fully connected operators. Note that this only contains gemm config entries for scalar kernels, and will be fleshed out when appropriate ISA-specific kernels are merged.
This PR is a WIP. Outstanding tasks are as follows: