-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command logic for credential management #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed Ctrl-F persistent_storage
in all files.
I added a task that maybe iter_credentials
usability could be improved. I wonder if I can remove the need to have iter_result
(with compromise of each item being a Result
).
I think that would be easier indeed! |
The command is tested against Chrome. To test, change the default permission in pin_protocol_v1.rs to self.permissions = 0x03 | PinPermission::CredentialManagement as u8; |
The 2 new commits don't show up in the conversation, since I merged after. The first is addressing the memory state issue. The other reworks the command state more to always reset timeout and state when either check fails. @jmichelp PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked occurrences of persistent_store
.
Together with #253 and #254, this PR implements the credential management command. Its logic is equivalent to #107, with the difference of only storing keys for credentials as state between calls to
EnumerateCredentialsGetNextCredential
.