cfu: generate rsp_valid without using cmd_valid #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Binkowski <[email protected]>
|
@piotr-binkowski what are the implications of this change? Combinational CFU operations are no longer allowed? Or were they not allowed previously? |
Open
|
Hi @piotr-binkowski Thanks for trying this out! I'd rather not make this change for all accelerators, as I'm not sure about the implications across the board, and the rewards are low (1-2 MHz). I'll think about this a little more after looking at the new critical paths reports. Alan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes combinational path from
cmd_validtorsp_validwhich slightly improves fMax (1-2MHz in recent tests) and FWIW doesn't impact model evaluation time.