Adapt to goldfirere/th-desugar#227 #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of a fix for goldfirere/th-desugar#223, goldfirere/th-desugar#227 adds its own version of `singletons-th`'s `matchUpSAKWithDecl` function (now called `dMatchUpSAKWithDecl` on the `th-desugar` side). This commit completes the migration by removing `singletons-th`'s version of `matchUpSAKWithDecl` and instead using the version offered by `th-desugar`.
As part of a fix for goldfirere/th-desugar#199 and goldfirere/th-desugar#220, goldfirere/th-desugar#227 improves `th-desugar`'s ability to locally reify and desugar precise types for Haskell98-style data constructors and class methods. This has a couple of knock-on effects for `singletons`: * The type of `dsCon` has changes to accept `DTyVarBndrSpec`s instead of `DTyVarBndrUnit`s, so we must adapt the call sites in `singletons-th` accordingly. * Some of the test cases in `singletons-base` need to have their expected output updated to account for the improved kind information and specificity information flowing down from standalone kind signatures.
RyanGlScott
force-pushed
the
adapt-to-th-desugar-T199-T220
branch
from
febfac4
to
f8b8cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adapts to the changes in goldfirere/th-desugar#227:
As part of a fix for Move
matchUpSAKWithDeclfromsingletons-thtoth-desugarth-desugar#223, Improve local reification and desugaring with respect to standalone kind signatures th-desugar#227 adds its own version ofsingletons-th'smatchUpSAKWithDeclfunction (now calleddMatchUpSAKWithDeclon theth-desugarside). This PR completes the migration by removingsingletons-th's version ofmatchUpSAKWithDecland instead using the version offered byth-desugar.As part of a fix for Desugared data constructor has incorrect type variable specificity th-desugar#199 and Reified class method has incorrect type variable specificity th-desugar#220, Improve local reification and desugaring with respect to standalone kind signatures th-desugar#227 improves
th-desugar's ability to locally reify and desugar precise types for Haskell98-style data constructors and class methods. This has a couple of knock-on effects forsingletons:dsConhas changes to acceptDTyVarBndrSpecs instead ofDTyVarBndrUnits, so we must adapt the call sites insingletons-thaccordingly.singletons-baseneed to have their expected output updated to account for the improved kind information and specificity information flowing down from standalone kind signatures.