Don't defunctionalize helpers for class defaults or instance methods #609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
singletons-th
generates "helper" type families that contain the definitions of class method defaults or instance methods. For example, this:Will be promoted to this:
Generating defunctionalization symbols for
MHelper
is wasteful, however, as we never really need to partially applyMHelper
. Instead, we can just generate this code:This takes advantage of the fact that when we apply
MHelper
, we always fully apply it to all of its arguments. This means that we can avoid generating defunctionalization symbols for helper type families altogether, which is a nice optimization.This patch implements that idea, fixing #608 in the process.