Require building with th-desugar-1.17
#584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the `th-desugar` commit in the `cabal.project` file's `source-repository-package` to bring in the changes from `th-desugar-1.17`. Among other things, this version of `th-desugar` adds support for: * Namespace specifiers in fixity declarations * Embedded type expressions and patterns * Invisible type patterns For now, `singletons-th` will error if it encounters any of these constructs. Where appropriate, I have opened issues to track the idea of supporting these language features in `singletons-th`: * For namespace specifiers in fixity declarations, see #582. * Supporting embedded type expressions and patterns seems quite difficult due to `singletons-th`'s policy of only promoting/singling vanilla type signatures (see the `README`), so I have not opened an issue for this. * For invisible type patterns, see #583. This is one step towards preparing a GHC 9.10–compatible release of `singletons` and friends (see #569).
RyanGlScott
force-pushed
the
th-desugar-1.17
branch
from
ac536bf
to
d19ab3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the
th-desugarcommit in thecabal.projectfile'ssource-repository-packageto bring in the changes fromth-desugar-1.17. Among other things, this version ofth-desugaradds support for:For now,
singletons-thwill error if it encounters any of these constructs. Where appropriate, I have opened issues to track the idea of supporting these language features insingletons-th:singletons-th's policy of only promoting/singling vanilla type signatures (see theREADME), so I have not opened an issue for this.This is one step towards preparing a GHC 9.10–compatible release of
singletonsand friends (see #569).