Update README.md section4.8 #1282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add missing content to section 4.8
| @@ -802,7 +802,7 @@ b. [Node.js testing - beyond the basics](https://github.com/testjavascript/nodej | |||
|
|
|||
| ## ![✔] 4.8 Use production-like environment for e2e testing | |||
|
|
|||
| **TL;DR:** End to end (e2e) testing which includes live data used to be the weakest link of the CI process as it depends on multiple heavy services like DB. Use an environment which is as close to your real production environment as possible like a-continue (Missed -continue here, needs content. Judging by the **Otherwise** clause, this should mention docker-compose) | |||
| **TL;DR:** End to end (e2e) testing which includes live data used to be the weakest link of the CI process as it depends on multiple heavy services like DB. Use an environment which is as close to your real production environment as possible like docker-compose set up which ensure (1) An easy way ro run the test by anyone, new developers, CI processes etc... (2) A repeatable and isolated running environment so that the outcome of the tests won’t vary depending from where they were run from, (3) Be as close as possible to the production environment. | |||
There was a problem hiding this comment.
Suggested change
| **TL;DR:** End to end (e2e) testing which includes live data used to be the weakest link of the CI process as it depends on multiple heavy services like DB. Use an environment which is as close to your real production environment as possible like docker-compose set up which ensure (1) An easy way ro run the test by anyone, new developers, CI processes etc... (2) A repeatable and isolated running environment so that the outcome of the tests won’t vary depending from where they were run from, (3) Be as close as possible to the production environment. | |
| **TL;DR:** End to end (e2e) testing which includes live data used to be the weakest link of the CI process as it depends on multiple heavy services like DB. Use an environment which is as close to your real production environment as possible like docker-compose set up which will ensure: | |
| - An easy way to run the test by anyone, new developers, CI processes etc. | |
| - A repeatable and isolated running environment so that the outcome of the tests won’t vary depending from where they were run from | |
| - Be as close as possible to the production environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing content to section 4.8