Fix undoredo handling in some dialogs #93898
Merged
+66
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added fix for UV edit. |
akien-mga
reviewed
Jul 4, 2024
Comment on lines
55
to
78
| class UVEditDialog : public AcceptDialog { | ||
| GDCLASS(UVEditDialog, AcceptDialog); | ||
|
|
||
| void UVEditDialog::shortcut_input(const Ref<InputEvent> &p_event) override { | ||
| const Ref<InputEventKey> k = p_event; | ||
| if (k.is_valid() && k->is_pressed()) { | ||
| bool handled = false; | ||
|
|
||
| if (ED_IS_SHORTCUT("ui_undo", p_event)) { | ||
| EditorNode::get_singleton()->undo(); | ||
| handled = true; | ||
| } | ||
|
|
||
| if (ED_IS_SHORTCUT("ui_redo", p_event)) { | ||
| EditorNode::get_singleton()->redo(); | ||
| handled = true; | ||
| } | ||
|
|
||
| if (handled) { | ||
| set_input_as_handled(); | ||
| } | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
I wonder if we should make this an editor class like AcceptDialogWithUndoRedo in editor/gui/?
For now doing it ad hoc is fine but if we find more similar occurrences we might want to consider using this in place of AcceptDialog for editor dialogs which need UndoRedo.
akien-mga
approved these changes
Jul 4, 2024
KoBeWi
force-pushed
the
rundo_edo
branch
2 times, most recently
from
30c7cfd
to
67bbd4d
Compare
akien-mga
reviewed
Jul 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like dialogs are blocking input from passing to the editor, so undo/redo shortcut has to be handled manually when relevant. I improved handling in some dialogs and fixed animation dialog, but there might be more dialogs that need fixing.
Fixes godotengine/godot-proposals#10062
7Z38LZN1ha.mp4
Fixes #88412