Core: Improve vformat error reporting on sprintf failure
#93897
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
cherrypick:4.2
akien-mga
changed the title
vformat error reporting on sprintf failure
akien-mga
changed the title
vformat error reporting on sprintf failurevformat error reporting on sprintf failure
akien-mga
commented
Jul 3, 2024
| @@ -857,7 +857,7 @@ String vformat(const String &p_text, const VarArgs... p_args) { | |||
| bool error = false; | |||
| String fmt = p_text.sprintf(args_array, &error); | |||
|
|
|||
| ERR_FAIL_COND_V_MSG(error, String(), fmt); | |||
| ERR_FAIL_COND_V_MSG(error, String(), String("Formatting error in string \"") + p_text + "\": " + fmt + "."); | |||
There was a problem hiding this comment.
Not using vformat here to avoid recursive calling.
And fix a few occurrences of formatting errors that led me to this.
akien-mga
force-pushed
the
vformat-better-error-message
branch
from
243ca77
to
496b7b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix a few occurrences of formatting errors that led me to this.
Example from the cases handled here: