Fix logic to determining rendering method #93863
Draft
+7
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jul 8, 2024
Comment on lines
-2142
to
-2146
| if (rendering_driver == "opengl3" || rendering_driver == "opengl3_angle" || rendering_driver == "opengl3_es") { | ||
| rendering_method = "gl_compatibility"; | ||
| } else { | ||
| rendering_method = "forward_plus"; | ||
| } |
There was a problem hiding this comment.
Does it still work without this code?
The purpose of this was that if you run godot --rendering-driver opengl3 or godot --rendering-driver vulkan, it will force the appropriate rendering method, even if the one configured in "rendering/renderer/rendering_method" is different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues in that regard:
I'm not completely sure this will not cause any regression in other cases of interaction between CLI, project settings and hardcoded defaults. Please review carefully.