CI: Make codespell checks blocking, but only check changed files #76828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
ci-codespell-blocking
branch
4 times, most recently
from
4a470bc
to
35bf7fc
Compare
|
Added a typo to test that it works:
The output could be improved somewhat so that the error suggests that the user can check the diff view of their PR to see where the typos were found. If anyone is interested something like this could be contributed upstream: https://github.com/codespell-project/actions-codespell |
akien-mga
force-pushed
the
ci-codespell-blocking
branch
from
a622740
to
b226f7e
Compare
|
Seems like codespell is now checking changed
|
|
This should fix it: #76842. |
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent typos from slipping in, while avoiding unnecessarily failing checks on unrelated PRs if some typos do get in by mistake (which seemed to happen frequently when those checks were only showing warnings in the diff view).
Using the method documented in codespell-project/actions-codespell#65