Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS Client support - bypass 403 Forbidden errors on sites like StockX, Indeed, etc! #784

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cullenwatson
Copy link

@cullenwatson cullenwatson commented Sep 28, 2023

Integrates https://github.com/bogdanfinn/tls-client which is a modern http client to bypass modern blocking techniques (TLS signatures)

I know this repo isn't maintained anymore but PRed for reach if anyone is struggling with this problem.

@WGH-
Copy link
Collaborator

WGH- commented Oct 16, 2023

It's really unfortunate this can't be just plugged as a transport with WithTransport. I'm not sure it's a good idea to infect the public API with custom types coming from third-party fhttp library (with unclear license status)

@kqvanity
Copy link

@cullenwatson I've tried your fork, and I ran into issues. The first one has to do with the module e.g., module declares its path as but was required as: which didn't get resolved until i matched the github repo name with the go.mod package name.

After the first one was resolved, it raised the issue

../../../go/pkg/mod/github.com/kqvanity/colly/[email protected]/colly.go:1174:30: cannot use cnew (variable of type []*"github.com/bogdanfinn/fhttp".Cookie) as []*"net/http".Cookie value in argument to storage.ContainsCookie
../../../go/pkg/mod/github.com/kqvanity/colly/[email protected]/colly.go:1175:24: cannot use c (variable of type *"net/http".Cookie) as *"github.com/bogdanfinn/fhttp".Cookie value in argument to append
../../../go/pkg/mod/github.com/kqvanity/colly/[email protected]/colly.go:1178:49: cannot use cnew (variable of type []*"github.com/bogdanfinn/fhttp".Cookie) as []*"net/http".Cookie value in argument to storage.StringifyCookies
../../../go/pkg/mod/github.com/kqvanity/colly/[email protected]/colly.go:1195:23: cannot use c (variable of type *"net/http".Cookie) as *"github.com/bogdanfinn/fhttp".Cookie value in argument to append
make: *** [makefile:2: run] Err

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants