Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TX virtual size call / Correct TX weight #538

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add TX virtual size call / Correct TX weight #538

wants to merge 1 commit into from

Conversation

droark
Copy link

@droark droark commented Nov 27, 2018 •
edited
Loading

  • The virtual size of a TX can be useful info to have, as it's what is used to calculate the fee when fee/byte is used. Allow users to get the virtual size.
  • The current TX weight call is actually the TX virtual size. Correct the call to provide the actual weight.

@droark droark force-pushed the dev-add-virt-size branch 6 times, most recently from c3a4009 to be29c80 Compare January 14, 2019 23:27
@droark droark force-pushed the dev-add-virt-size branch 2 times, most recently from 20c0436 to 0d0564b Compare January 26, 2019 00:57
@droark droark changed the title Add virtual size to TX Add TX virtual size call / Correct TX weight Jan 26, 2019
@droark droark force-pushed the dev-add-virt-size branch 5 times, most recently from 0f40b67 to f541ad9 Compare February 10, 2019 00:24
@droark droark force-pushed the dev-add-virt-size branch 3 times, most recently from dd111bf to bdc3ba9 Compare February 19, 2019 19:48
@droark
Add TX virtual size call / Correct TX weight
396d998 
- The virtual size of a TX can be useful info to have, as it's what is used to calculate the fee when fee/byte is used. Allow users to get the virtual size.
- The current TX weight call is actually the TX virtual size. Correct the call to provide the actual weight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@droark