Fix header warnings (Part 1) #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droark
force-pushed
the
dev_fix_warnings_1
branch
2 times, most recently
from
0c9a66d
to
c646bfc
Compare
droark
changed the title
goatpig
reviewed
Nov 15, 2018
droark
force-pushed
the
dev_fix_warnings_1
branch
2 times, most recently
from
04fc14c
to
ebc07f6
Compare
|
Fixed. |
droark
force-pushed
the
dev_fix_warnings_1
branch
from
ebc07f6
to
c926dd8
Compare
droark
force-pushed
the
dev_fix_warnings_1
branch
from
c926dd8
to
63c87dc
Compare
|
This PR needs to be double checked. This has been rebased after the wave of warning fixes. Some of my fixes are still necessary. This PR may also introduce new warnings (or errors)! I'll check it again later. |
droark
force-pushed
the
dev_fix_warnings_1
branch
2 times, most recently
from
84809e4
to
3e4eb16
Compare
droark
force-pushed
the
dev_fix_warnings_1
branch
3 times, most recently
from
7d0b80c
to
6c03f1d
Compare
droark
force-pushed
the
dev_fix_warnings_1
branch
from
6c03f1d
to
99dac4b
Compare
droark
force-pushed
the
dev_fix_warnings_1
branch
5 times, most recently
from
e997469
to
49defe0
Compare
droark
force-pushed
the
dev_fix_warnings_1
branch
3 times, most recently
from
a38ad27
to
8129124
Compare
droark
force-pushed
the
dev_fix_warnings_1
branch
from
8129124
to
31552b0
Compare
droark
force-pushed
the
dev_fix_warnings_1
branch
from
31552b0
to
288e201
Compare
droark
force-pushed
the
dev_fix_warnings_1
branch
from
288e201
to
5e58470
Compare
Armory has a *lot* of warnings in its C++ code (not including third-party code, which is typically not touched). Start the process of fixing the warnings, starting with header files (more annoying as they can occur over & over). Warnings fixed include but are not limited to: -Wreorder, -Wunused-parameter, -Wformat-nonliteral, and -Wsign-compare
droark
force-pushed
the
dev_fix_warnings_1
branch
from
5e58470
to
65a1187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Armory has a lot of warnings in its C++ code (not including third-party code, which is typically not touched). Start the process of fixing the warnings, starting with header files (more annoying as they can occur over & over). Warnings fixed include but are not limited to: -Wreorder, -Wunused-parameter, -Wformat-nonliteral, -Wsign-compare, and -Wmaybe-uninitialized.