Compatibility rework 2 #1366
Open
Compatibility rework 2 #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed ToolDownloader to UnixHelpers * Moved DxvkHud and MangoHud checkers to UnixHelpers * Removed unneeded "using" statements * Added flatpak and extraEnvironmentVars for future use
This was referenced Jul 26, 2023
Closed
marzent
reviewed
Aug 1, 2023
src/XIVLauncher.Common.Unix/Compatibility/CompatibilityTools.cs
Outdated
Show resolved
Hide resolved
src/XIVLauncher.Common.Unix/Compatibility/CompatibilityTools.cs
Outdated
Show resolved
Hide resolved
src/XIVLauncher.Common.Unix/Compatibility/CompatibilityTools.cs
Outdated
Show resolved
Hide resolved
* Moved download funcs to CompatibilityTools * Moved hud funcs to DxvkSettings * Simplified MergeLDPreload * Cleaned up formatting, deleted a commented-out function
marzent
approved these changes
Aug 2, 2023
rankynbass
force-pushed
the
compatibility-rework-2
branch
from
7413677
to
dd1d2a3
Compare
This should allow auto-merging with master.
|
This is ready to go. Can we get it merged so XL.Core can have modern wine and dxvk? |
|
Requesting re-review, since it's been so long. There haven't been any major changes, mostly just tweaks to make sure it still merges cleanly. The only changes are removing the dxvk.conf override, so people can find it in the game folder where it's expected, and tweaking some mangohud defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a new version of the compatibility rework. This version moves most of the logic back to XL.Common.Unix.
Wine download info, Dxvk download info, and various hud settings are passed to CompatibiltyTool, WineSettings, or DxvkSettings (instead of being pre-assembled as dictionary objects as in the previous PR). The necessary environment variables are created inside CompatibilityTool or DxvkSettings.
Here's the XL.Core PR: goatcorp/XIVLauncher.Core#64
Replaces #1348