[Add-Feature] Add custom DXVK_HUD option #1119
Conversation
quasd
changed the title
merge upstream
| @@ -276,7 +277,7 @@ public static void CreateCompatToolsInstance() | |||
| { | |||
| var wineLogFile = new FileInfo(Path.Combine(storage.GetFolder("logs").FullName, "wine.log")); | |||
| var winePrefix = storage.GetFolder("wineprefix"); | |||
| var wineSettings = new WineSettings(Config.WineStartupType, Config.WineBinaryPath, Config.WineDebugVars, wineLogFile, winePrefix, Config.ESyncEnabled, Config.FSyncEnabled); | |||
| var wineSettings = new WineSettings(Config.WineStartupType, Config.WineBinaryPath, Config.DxvkHudCustomString, Config.WineDebugVars, wineLogFile, winePrefix, Config.ESyncEnabled, Config.FSyncEnabled); | |||
There was a problem hiding this comment.
Probably a better idea to not put dxvk related config into WineSettings, especially considering since we just pass DxvkHudType and DxvkAsyncEnabled into the CompatibilityTools ctor currently.
Ideally DxvkHudCustomString is in there as well, or even better just put all dxvk related settings into their own class like DxvkSettings ,
There was a problem hiding this comment.
Also consider that dxvk can also be used on windows, even though this is currently not in the scope of what XL provides it is possible, and for example an option in the GShade windows installer
There was a problem hiding this comment.
Using dxvk on Windows is something we should never support. (It also will crash dalamud)
It honestly led to a support nightmare when the gshade installer started providing it as an option.
DXVK options should only be available for Wine platforms.
| @@ -24,10 +25,11 @@ public class WineSettings | |||
|
|
|||
| public DirectoryInfo Prefix { get; private set; } | |||
|
|
|||
| public WineSettings(WineStartupType? startupType, string customBinPath, string debugVars, FileInfo logFile, DirectoryInfo prefix, bool? esyncOn, bool? fsyncOn) | |||
| public WineSettings(WineStartupType? startupType, string customBinPath, string dxvkHudCustomString, string debugVars, FileInfo logFile, DirectoryInfo prefix, bool? esyncOn, bool? fsyncOn) | |||
There was a problem hiding this comment.
A bit nit-picky but there is an extra space before FileInfo here (well and it is better to not have dxvk stuff here as well)
I basically have no idea what I am doing (dotnet?), if there is anything you would like to be changed let me know.
The current options for DXVK_HUD were not enough so I implemented custom switch for it.
Only visible when set to custom:
Result in game:
Tested on: arch
build with customized: https://aur.archlinux.org/packages/xivlauncher-git