Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EzWondrousTails v3.2.0.3 #5051

Merged
merged 2 commits into from
Nov 24, 2024
Merged

EzWondrousTails v3.2.0.3 #5051

merged 2 commits into from
Nov 24, 2024

Conversation

MidoriKami
Copy link
Contributor

Actually fixes incorrect scaling on border nodes in the book.

@bleatbot bleatbot enabled auto-merge (squash) November 23, 2024 15:53
@MidoriKami
Copy link
Contributor Author

Went the wrong way on the scaling with the last update... oops.

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 23, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 4 hours.

Name Commit Status
WondrousTailsSolver [stable] 1dfb448 Build failed (Diff)
14 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib.git e9967f072db525968ef52d66270a724fc5434863 reiichi001
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 23, 2024
@philpax
Copy link
Contributor

philpax commented Nov 23, 2024

Man, your plugins are cursed. I hope goat can get to the bottom of this at some point.

@MidoriKami
Copy link
Contributor Author

It's specifically using dalamud.NET.sdk inside library projects that's not working correctly in plogon. It used to be fine, but something changed with dalamudpackager (I assume) that's making it not play well anymore.

Goat suggested in another post, that releasing a version of dalamud.NET.sdk that doesn't include dalamud packager, would make it suitable for use in library projects like KamiToolKit and KamiLib.

@MidoriKami
Copy link
Contributor Author

MidoriKami commented Nov 23, 2024

With dalamud targets also having the same issue, and being depricated eventually, I would have to go back to defining all the project references manually, which I would very much rather not do given that we should be able to use nice things like dalamud.NET.sdk

So I'll leave these failed builds here as a reminder of this issue, unless I am told by goat that they no longer plan to support library projects like KamiLib with dalamud.NET.sdk

@MidoriKami MidoriKami changed the title EzWondrousTails v3.2.0.2 EzWondrousTails v3.2.0.3 Nov 24, 2024
auto-merge was automatically disabled November 24, 2024 21:42

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ WondrousTailsSolver [stable] 4867a37 v3.2.0.3 - Diff (8 lines, prev. 3.2.0.1) - Semantic
14 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib.git 79ccadc60048b91b01bd06ddf9f13056595d9f9f ⚠️ Upd. from d210e7ac29c9c733b21bc0a13c3e53607aedf986
Submodule https://github.com/MidoriKami/KamiToolKit.git 2f907055d4fda5562999996286a8f39723512c62 ⚠️ Upd. from 8027b76b17f649ccd379e14598858d60dd6a9d42
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-small Diff for this PR is small. and removed build failed This plugin failed to build. labels Nov 24, 2024
@reiichi001 reiichi001 merged commit 04b4ede into goatcorp:main Nov 24, 2024
2 checks passed
@MidoriKami MidoriKami deleted the patch-79 branch November 24, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small Diff for this PR is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants