Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3484629: Lock the socialbase version to avoid conflicts #4222

Closed
wants to merge 6 commits into from
Closed

Issue #3484629: Lock the socialbase version to avoid conflicts #4222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fec8d06
Lock the socialbase version so we don't run into issues with patches …
Dec 2, 2024
ca86c4f
try out change in workflow with version 12
Dec 2, 2024
fe88560
another try
Dec 2, 2024
810864d
another try
Dec 2, 2024
0ec84fa
Revert
Dec 2, 2024
71bdeb6
another test
Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/behat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
# Also include a hardcoded version for instaclick/php-webdriver, drupal/dynamic_entity_reference and drupal/core
# as we didnt lock the version, and the patch isn't applying on the latest, so we require it
# specifically to match the version that was installed at that moment in time.
composer require goalgorilla/open_social:~$PREVIOUS_MAJOR instaclick/php-webdriver:1.4.16
composer require "goalgorilla/open_social:dev-issue/combine-patches-url-embed as 12.4.7" instaclick/php-webdriver:1.4.16

# Installation
# This is purposefully duplicated because we may change how
Expand Down
4 changes: 1 addition & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@
"Ensure field definition allowed values callbacks are used for field filter callbacks": "https://www.drupal.org/files/issues/2023-12-26/views_filter_options_callback--2949022-17.patch",
"Issue #3454939: Declaration of Drupal\\search_api_solr\\Plugin\\search_api\\backend\\SearchApiSolrBackend::__sleep() must be compatible": "https://www.drupal.org/files/issues/2024-06-17/3454939-search-api-solr-core-10.patch"
},
"drupal/socialbase": {
"Issue #3484629: Add bootstrap patch for Drupal 11 compatibility": "https://www.drupal.org/files/issues/2024-10-30/3484629-3-add-bootstrap-patch-to-be-compatible-with-d11.patch"
},
"drupal/url_embed": {
"Translate dialog title": "https://www.drupal.org/files/issues/2018-03-16/url_embed_translate_dialog_title-2953591-2.patch",
"Issue #2761187/#3386579 Improve how the module deals with non-embeddable URLs & WSODs (See: https://www.drupal.org/project/social/issues/3386579#comment-15225972) 2.x": "https://www.drupal.org/files/issues/2023-09-22/urlembed-non-embeddable-urls-2761187-opensocial-combined-21_2.x_1_ckeditor5.patch",
Expand Down Expand Up @@ -170,6 +167,7 @@
"drupal/search_api_solr": "4.3.5",
"drupal/select2": "1.15.0",
"drupal/shariff": "2.0.0",
"drupal/socialbase": "2.6.8",
"drupal/socialblue": "2.6.5",
"drupal/symfony_mailer": "^1.2",
"drupal/token": "1.15.0",
Expand Down
Loading