Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3477793: Fix social_group_flexible_group_update_130006 update #4204

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

rochek03
Copy link
Contributor

@rochek03 rochek03 commented Nov 26, 2024

Problem (for internal)

The social_group_flexible_group_update_130006 was failing because of an already existing "verified" role.

Solution (for internal)

The config name of the group role could be hashed if the length of the name is longer than 32 symbols, so we can't check configs by name, so we should check if such a role exists by GroupRole entity properties.

Release notes (to customers)

Internal.

Issue tracker

@rochek03 rochek03 added type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review prio: high labels Nov 26, 2024
@rochek03 rochek03 added this to the 13.0.0-alpha19 milestone Nov 26, 2024
@rochek03 rochek03 requested a review from ribel November 26, 2024 16:11
Copy link
Contributor

@ribel ribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update hook was tested on site where it was failing before and now it works as expected.

Before:
image

After:
image

@ribel ribel merged commit 4eaeb5d into main Nov 27, 2024
197 checks passed
@ribel ribel deleted the hotfix/3477793-fix-verified-user-role-update branch November 27, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

2 participants