Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-31337: Implement group update event for EDA #4197

Merged

Conversation

nkoporec
Copy link
Contributor

Problem (for internal)

Currently we don't have an EDA event that fires when a group is updated.

Solution (for internal)

Create a new event for this.

Payload:

{
	"specversion": "1.0",
	"id": "d1b7cf62-8901-49e6-b7f4-c01926323be1",
	"source": "/group/25/edit",
	"type": "com.getopensocial.cms.group.update",
	"datacontenttype": "application/json",
	"time": "2024-11-22T13:57:34Z",
	"data": {
		"group": {
			"id": "7c2163c1-28bc-4d6d-b90e-bd1ecc77af7f",
			"created": "2024-11-22T13:57:34",
			"updated": "2024-11-22T14:14:00",
			"status": "published",
			"label": "2uoeuTesteueouu",
			"visibility": {
				"type": "public",
				"roles": []
			},
			"contentVisibility": "community",
			"membership": {
				"method": "request"
			},
			"type": "27aaa381-4322-4096-9cfa-63d4df67d538",
			"author": {
				"id": "53bb767a-cdc0-4872-81eb-9a4db10374bf",
				"displayName": "admin",
				"href": {
					"canonical": "https://opensocial.ddev.site/user/1/home"
				}
			},
			"address": {
				"label": "",
				"countryCode": "",
				"administrativeArea": "",
				"locality": "",
				"dependentLocality": "",
				"postalCode": "",
				"sortingCode": "",
				"addressLine1": "",
				"addressLine2": ""
			},
			"href": {
				"canonical": "https://opensocial.ddev.site/group/25/stream"
			}
		},
		"actor": {
			"application": null,
			"user": {
				"id": "53bb767a-cdc0-4872-81eb-9a4db10374bf",
				"displayName": "admin",
				"href": {
					"canonical": "https://opensocial.ddev.site/user/1/home"
				}
			}
		}
	}
}

Release notes (to customers)

Issue tracker

https://getopensocial.atlassian.net/browse/PROD-31337

Theme issue tracker

How to test

  • Set up social_eda and dispatcher module
  • As an admin create a new group
  • As an admin update the new group and set a new title
  • Check Kafka for messages and assert that a new event for group update has been dispatched.

Change Record

Translations

@nkoporec nkoporec added team: enterprise This PR originates from the ECI team type: feature Adds a new feature to Open Social status: needs review This pull request is waiting for a requested review prio: medium labels Nov 22, 2024
@nkoporec nkoporec added this to the 13.0.0-alpha19 milestone Nov 22, 2024
@nkoporec nkoporec force-pushed the feat/enterprise/PROD-31337/implement-group-update-event branch 4 times, most recently from 993b5fe to 5239efe Compare November 27, 2024 15:09
@ribel ribel changed the title PROD-31337 - Implement group update event for EDA PROD-31337: Implement group update event for EDA Dec 2, 2024
@ribel ribel force-pushed the feat/enterprise/PROD-31337/implement-group-update-event branch from 5239efe to 0428601 Compare December 2, 2024 18:37
@ribel ribel self-requested a review December 2, 2024 19:40
Copy link
Contributor

@ribel ribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ribel ribel merged commit 30647e9 into main Dec 2, 2024
195 checks passed
@ribel ribel deleted the feat/enterprise/PROD-31337/implement-group-update-event branch December 2, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: feature Adds a new feature to Open Social
Development

Successfully merging this pull request may close these issues.

2 participants