Issue #3487312: Site managers can't see content of groups they are not part of #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcsvinicius
added
type: bug
…cessControlHandler The 'bypass group access' permission isn't available anymore and the 'bypass create group access' should be enought because CM and SM already have this permission.
vcsvinicius
force-pushed
the
bugfix/3487312/sm-cannot-see-content-of-groups
branch
from
e202f99 to
7196b26
Compare
| @@ -205,7 +224,11 @@ public function query():void { | |||
| $post_access = new Condition('AND'); | |||
| $post_access->condition('activity__field_activity_entity.field_activity_entity_target_type', 'post'); | |||
|
|
|||
| if (!$account->hasPermission('bypass group access')) { | |||
| // Get group from url-parameter. | |||
| $group = $this->routeMatch->getParameter('group'); | |||
There was a problem hiding this comment.
you are lucky that #4118 is not merged yet, it brings a current group service that could have been used. :)
|
Tested and all good. |
vcsvinicius
deleted the
bugfix/3487312/sm-cannot-see-content-of-groups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (for internal)
The site-managers is not able to see the content in groups that they are not part of. So as for now, the group membership kind of outweighs the site manager status, which should not be the case.
Solution (for internal)
We are using 'bypass group access' permission from group module and it was removed after version 2, check #3259076
So I changed the validation to check group-permission from logged user.
Release notes (to customers)
Fixed access from site-manager at group contents without be part of them.
Issue tracker
PROD-31123
#3487312
Theme issue tracker
N/A
How to test
Change Record
N/A
Translations
N/A