Issue #3470128: Make quick join configurable for custom group types

[ronaldtebrake]

Problem && Solution

We used to load all roles / group types based on if -outsider is part of the name. This worked fine for a lot of the circumstances of the old group type where this was the case. Now, with the move to Group v2, oustider became a scope of the actual group role. So to make this compatible, we load all group roles, and figure out if we have a role with outsider scope that has the permission to join groups. Any group types without an outsider scope and or the join group permission we can't configure. As that means there is no group role specified that is able to quickjoin.

Issue tracker

https://www.drupal.org/project/social/issues/3470128

How to test

• Create custom group type, with outsider scoped roles, that don't have -outsider as part of the group name.
• See that the quick join page doesn't give an error
• See that all the group types are showing with an outsider role that has join group

Release notes

Make sure quick join group has all group types available, including custom ones.

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr4046-ll0mpqwsuhreyeh3ljvwsftydintcswg.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/66caed191976d4322956e3dc