Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few issues #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix a few issues #48

wants to merge 1 commit into from

Conversation

raphael
Copy link
Member

@raphael raphael commented Nov 28, 2024

  • Make sure that adding a dispatch return event to a node stream creates the stream if needed. This could cause jobs that are added right on startup to fail to be dispatched.
  • Fix potential panic in cleanup goroutine when the pending jobs map contains nil values
  • Make sure to close all maps when closing the node.
  • Properly log event information when discarding stale ack events.
  • More consistent logging

@raphael
Fix a few issues
785f03b 
* Make sure that adding a dispatch return event to a node stream creates the stream if needed.
  This could cause jobs that are added right on startup to fail to be dispatched.
* Fix potential panic in cleanup goroutine when the pending jobs map contains nil values
* Make sure to close all maps when closing the node.
* Properly log event information when discarding stale ack events.
* More consistent logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raphael